Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2077): add grid-auto props and stylePreset overrides to GridLayout #447

Merged

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Nov 1, 2022

PPDSC-2077

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label Nov 1, 2022
scripts/templates-integration-test/next.config.js Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
src/grid-layout/styled.ts Outdated Show resolved Hide resolved
@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Nov 2, 2022
src/grid-layout/styled.ts Outdated Show resolved Hide resolved
LukeFinch
LukeFinch previously approved these changes Nov 2, 2022
Copy link
Contributor

@LukeFinch LukeFinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good!

mutebg
mutebg previously approved these changes Nov 2, 2022
LukeFinch
LukeFinch previously approved these changes Nov 2, 2022
@Xin00163 Xin00163 dismissed stale reviews from LukeFinch and mutebg via 6ad310c November 2, 2022 13:35
@Xin00163
Copy link
Contributor Author

Xin00163 commented Nov 2, 2022

After #419 is merged, applying stylePreset to gridLayout will result in styles being applied twice as Flag is now using GridLayout. A lot of components are built on top of flag. This result in more than 300 snapshot changes. After chatting with @mutebg , we decided not to add stylePreset to GridLayout overrides for now.

@Xin00163 Xin00163 merged commit 3f42dc3 into main Nov 2, 2022
@Xin00163 Xin00163 deleted the feat/PPDSC-2077-add-grid-auto-and-stylePreset-to-GridLayout branch November 2, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants