Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(PPDSC-2471): release website with every merge to main #435

Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2471

What

  1. Background - There is a manual approve step approve_publish_docs_&_storybook which is now working properly and we have to remove it so the docs and storybook deployment happens automatically on every push to main

  2. What did you do - updated the config.yml file to remove the approval step

  3. What does the reviewers should expect - When this PR is merged this step should be removed and the pipeline should automatically deploy docs and storybook to prod.

image

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed task A non user facing change labels Oct 25, 2022
@evgenitsn evgenitsn changed the title ci(PPDSC-2471): remove the manual approve step ci(PPDSC-2471): release website with every merge to main Oct 25, 2022
@evgenitsn evgenitsn merged commit 12ab831 into main Oct 25, 2022
@evgenitsn evgenitsn deleted the ci/PPDSC-2471-remove-manual-deploy-to-prod-step-for-docs branch October 25, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed task A non user facing change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants