docs(PPDSC-2444): update flag component scenarios + layout updates #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenitsn
added
ready for review
evgenitsn
requested review from
jps,
Xin00163,
pdimova,
baburay23,
mutebg,
Vanals and
Srinivasan-Ramasamy
as code owners
|
You can preview these changes on: |
evgenitsn
removed
the
ready for design review
mutebg
reviewed
Oct 6, 2022
| </Block> | ||
| </Container> | ||
| </> | ||
| StoryInverse.storyName = 'Inverse flag'; |
There was a problem hiding this comment.
I wonder if we should call this just Inverse?
There was a problem hiding this comment.
It was initially Inverse but design team asked to change it to Inverse flag
mstuartf
approved these changes
Oct 6, 2022
mutebg
approved these changes
Oct 7, 2022
evgenitsn
changed the title
evgenitsn
deleted the
feat/PPDSC-2444-update-flag-component-storybook-scenarios
branch
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
) * docs(PPDSC-2444): update flag component scenarios + layout updates * docs(PPDSC-2444): update flag columns layout * docs(PPDSC-2444): address design comments * docs(PPDSC-2444): fix welcome screen dark theme * docs(PPDSC-2444): update stories layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2444
What
<StorybookPage/>and<StorybookCase/>components to be more flexible. Please use these wrappers for all future stories transformation and adapt them accordingly if needed.<StorybookPage/>and<StorybookCase/>for building the scenarios layout in order to keep consistent look throughout all stories.TextAreaandFlagare using them.I have done:
I have tested manually:
After:
Before:
Who should review this PR:
How to test:
Go to Flag stories in storybook PR link and have a look.