Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(PPDSC-2404): add version back into image name for dev deploy #361

Merged
merged 1 commit into from
Sep 5, 2022
Merged

build(PPDSC-2404): add version back into image name for dev deploy #361

merged 1 commit into from
Sep 5, 2022

Conversation

jps
Copy link
Contributor

@jps jps commented Sep 5, 2022

PPDSC-2404

What

  1. Background - why this is needed, develop env deploy is broken
  2. What did you do - added version back in for image name that pushed to ECS
  3. What does the reviewers should expect - both ECS and flux should have version and has in the image name

@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2404-fix-develop-deploy
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2404-fix-develop-deploy/storybook

@jps jps added the ready for review Please assist in getting this reviewed label Sep 5, 2022
@jps jps merged commit 7e520bb into main Sep 5, 2022
@jps jps deleted the build/PPDSC-2404-fix-develop-deploy branch September 5, 2022 16:07
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
build(PPDSC-2404): add version back into image name for dev deploy (#361
a4b53a8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xin00163 Xin00163 Xin00163 approved these changes

@Vanals Vanals Vanals approved these changes

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@mutebg mutebg Awaiting requested review from mutebg

@evgenitsn evgenitsn Awaiting requested review from evgenitsn

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jps @newskit-engineering @Xin00163 @Vanals