Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2322): add tealiumTrack to instrumentation #352

Merged
merged 10 commits into from
Sep 9, 2022

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Aug 26, 2022

PPDSC-2322

  • created createTealiumTrackHandler using window.tealiumTrack() instead of utag.
  • Add tracking to props table in component api

TO DO:

  • Check with Data Analytic team if the implementation is correct and confirm they can receive data from the componentAPI table.
  • Also check if we should replace tealiumHandler with tealiumTrackHandler

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Aug 26, 2022
@Xin00163 Xin00163 marked this pull request as ready for review August 26, 2022 10:34
@newskit-engineering
Copy link
Collaborator

@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Sep 6, 2022
@Xin00163 Xin00163 requested a review from mutebg September 6, 2022 08:55
mutebg
mutebg previously approved these changes Sep 9, 2022
@baburay23 baburay23 self-requested a review September 9, 2022 10:15
baburay23
baburay23 previously approved these changes Sep 9, 2022
@Xin00163 Xin00163 dismissed stale reviews from baburay23 and mutebg via 6948fe4 September 9, 2022 12:54
@Xin00163 Xin00163 merged commit c5c6629 into main Sep 9, 2022
@Xin00163 Xin00163 deleted the docs/PPDSC-2322-track-props-table branch September 9, 2022 18:24
Xin00163 added a commit that referenced this pull request Oct 17, 2022
* feat(PPDSC-2322): add tealiumTrack to instrumentation

* fix(PPDSC-2322): address comments

* fix(PPDSC-2322): data team comments

* fix(PPDSC-2322): add title for text block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants