Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2302): remove dev deps from package.json #341

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Aug 18, 2022

PPDSC-2302

What

  1. Background - we published dev packages to our components library
  2. What did you do - removed 2 packages which are not needed, update license and repository
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the fix This change fixes a bug label Aug 18, 2022
@newskit-engineering
Copy link
Collaborator

@mutebg mutebg marked this pull request as ready for review August 22, 2022 06:23
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Aug 22, 2022
mstuartf
mstuartf previously approved these changes Aug 22, 2022
Vanals
Vanals previously approved these changes Aug 22, 2022
@mutebg mutebg dismissed stale reviews from Vanals and mstuartf via c541f90 August 22, 2022 14:21
@mutebg mutebg requested review from Vanals and mstuartf August 22, 2022 14:25
@mutebg mutebg changed the title fix(PPDSC-2376): remove dev deps from package.json fix(PPDSC-2302): remove dev deps from package.json Aug 22, 2022
package.json Show resolved Hide resolved
@mutebg mutebg merged commit bea06d4 into main Aug 23, 2022
@mutebg mutebg deleted the fix/PPDSC-2376-remove-dev-deps branch August 23, 2022 12:45
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* fix(PPDSC-2376): remove dev deps from package.json

* fix(PPDSC-2376): add license and repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants