chore(PPDSC-2234): investigate Storybook analytics #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview these changes on: |
mutebg
requested review from
jps,
Xin00163,
pdimova,
baburay23,
Vanals,
evgenitsn and
Srinivasan-Ramasamy
as code owners
Vanals
reviewed
Sep 7, 2022
| }; | ||
|
|
||
| if (window && window.tealiumTrack) { | ||
| console.log('SEND_EVENT', event); |
Vanals
reviewed
Sep 7, 2022
| if (window && window.tealiumTrack) { | ||
| console.log('SEND_EVENT', event); | ||
| window.tealiumTrack(event); | ||
| // window.utag.view(e); |
Vanals
reviewed
Sep 7, 2022
| }, | ||
| consent: { | ||
| accountId: 259, | ||
| //TODO: change to https://storybook.newskit.co.uk |
evgenitsn
previously approved these changes
Sep 23, 2022
mstuartf
reviewed
Sep 26, 2022
| }; | ||
|
|
||
| addons.register(ADDON_ID, api => { | ||
| // The addon only sets the |
| // send initial page view event, since storybook doesn't do it via STORY_CHANGED | ||
| // When the preview boots, the first story is chosen via a selection specifier | ||
| api.on(STORY_SPECIFIED, () => { | ||
| console.log('STORY_SPECIFIED'); |
There was a problem hiding this comment.
Do we need the console logs?
baburay23
approved these changes
Sep 30, 2022
Xin00163
reviewed
Sep 30, 2022
Xin00163
approved these changes
Sep 30, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
* chore(PPDSC-2234): investigate Storybook analytics * chore(PPDSC-2234): change addon * chore(PPDSC-2234): change tracking function * chore(PPDSC-2234): use newskit components * chore(PPDSC-2234): update storybook and plugins * chore(PPDSC-2234): configure source point * chore(PPDSC-2234): update snapshots * chore(PPDSC-2234): update storybook * chore(PPDSC-2234): update label * chore(PPDSC-2234): config tealium profilleid * chore(PPDSC-2234): enable tracking * chore(PPDSC-2234): add page name * chore(PPDSC-2234): fix fonts paths * chore(PPDSC-2234): fix deps * chore(PPDSC-2234): fix undefined error * chore(PPDSC-2234): fix js error * chore(PPDSC-2234): fix object * chore(PPDSC-2234): adress comments * chore(PPDSC-2234): update privacy policy link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2234
What
2.1. Created a storybook plugin which utilises our Tealium and Consent component so we can track
2.2. Fixed Tealium component to take reactHelmet prop as its described in the docs.
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: