docs(PPDSC-2299): newskit new homepage hero section #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenitsn
requested review from
jps,
Xin00163,
pdimova,
baburay23,
mutebg,
Vanals and
Srinivasan-Ramasamy
as code owners
|
You can preview these changes on: |
evgenitsn
added
ready for design review
evgenitsn
added
ready for review
mutebg
reviewed
Aug 11, 2022
mutebg
reviewed
Aug 11, 2022
mutebg
reviewed
Aug 12, 2022
mutebg
reviewed
Aug 12, 2022
mutebg
approved these changes
Aug 12, 2022
Vanals
approved these changes
Aug 15, 2022
evgenitsn
deleted the
docs/PPDSC-2299-newskit-new-homepage-hero-section
branch
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
* docs(PPDSC-2299): newskit new homepage hero section * docs(PPDSC-2299): update background image rules * docs(PPDSC-2299): revert typography presets changes * docs(PPDSC-2299): fixed background and reorganise files * docs(PPDSC-2299): improve CTA buttons * docs(PPDSC-2299): hero background updates * docs(PPDSC-2299): update grid illustration * docs(PPDSC-2299): address comments * docs(PPDSC-2299): update grid structure * docs(PPDSC-2299): update maxWidth * docs(PPDSC-2299): update grid containers * docs(PPDSC-2299): remove unused `themeMode`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2299
What
Added Hero Section to the new Newskit Homepage. The dynamic components part is a separate ticket.
There are some discrepancies between Figma and Newskit typography and dark theme colours, so currently there are a few bits that are not exact look compared to the design. The design team is aware of that and this would be handled in a separate ticket.
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: