Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2259): skeleton of homepage #318

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Jul 28, 2022

PPDSC-2259

This is a small ticket to lay out the build the skeleton of the homepage. Each section is currently being occupied by a placeholder.

To review please visit:
http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2259-homepage-gridlayout/index-new

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Jul 28, 2022
@newskit-engineering
Copy link
Collaborator

@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Aug 1, 2022
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Xin00163 Xin00163 merged commit 37eb09c into main Aug 2, 2022
@Xin00163 Xin00163 deleted the docs/PPDSC-2259-homepage-gridlayout branch August 2, 2022 08:45
Xin00163 added a commit that referenced this pull request Oct 17, 2022
* docs(PPDSC-2259): skeleton of homepage

* fix(PPDSC-2259): update footer links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants