Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ppdsc 2143 volume control horizontal expand #306

Merged
merged 29 commits into from
Aug 9, 2022

Conversation

baburay23
Copy link
Contributor

@baburay23 baburay23 commented Jul 20, 2022

PPDSC-2143

What

  1. Background - horizontal expandable needed on volume control
  2. What did you do- layout prop has been extended to 'horizontal' | 'horizontalCollapsed' | 'horizontalExpandable' | 'vertical'. The default is 'horizontalExpandable' . i have removed the old collapsed prop
    We also created a new transitionPreset 'widthChange' to apply transition to the expandable div. This is now also overridable by the user. I have also added in documentation for this transitionPreset and stories approved by design
  3. What does the reviewers should expect-volume control has four layout options, transition is now applied to 'horizontlExpandable'
    http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2143-volume-control-horizontal-expand/storybook/?path=/story/newskit-light-audio-player-composable--audio-player-volume-control-layout

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label Jul 20, 2022
@baburay23 baburay23 added the ready for review Please assist in getting this reviewed label Jul 28, 2022
@baburay23 baburay23 requested a review from Xin00163 August 1, 2022 14:16
@baburay23 baburay23 requested a review from mstuartf August 4, 2022 13:26
@baburay23 baburay23 merged commit 95df70d into main Aug 9, 2022
@baburay23 baburay23 deleted the feat/PPDSC-2143-volume-control-horizontal-expand branch August 9, 2022 13:40
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* feat(PPDSC-2143): chore-ppdse-2143-added expand

* feat(PPDSC-2143): chore-ppdse-2143-added types

* feat(PPDSC-2143): chore-ppdse-2143-layout options working

* feat(PPDSC-2143): chore-ppdse-2143-tidied up

* feat(PPDSC-2143): chore-ppdse-2143-transition ahrd coded

* feat(PPDSC-2143): chore-ppdse-2143-added stories

* feat(PPDSC-2143): chore-ppds-2143-motion working

* feat(PPDSC-2143): chore-ppds-2143-horizonal working

* feat(PPDSC-2143): chore-ppds-2143-added visible

* feat(PPDSC-2143): chore-ppds-2143-tideid up

* feat(PPDSC-2143): chore-ppds-2143-updated snapshots and sotires

* feat(PPDSC-2143): chore-ppds-2143-added tests for styled.ts

* feat(PPDSC-2143): chore-ppds-2143-tests 100%

* feat(PPDSC-2143): chore-ppds-2143-updated stories

* feat(PPDSC-2143): chore-ppds-2143-updated tests

* feat(PPDSC-2143): chore-ppds-2143-removed comments

* feat(PPDSC-2143): chore-ppds-2143-fixed aria-landmark

* feat(PPDSC-2143): chore-ppds-2143-updated docs

* feat(PPDSC-2143): chore-ppds-2143-addressed comments

* feat(PPDSC-2143): chore-ppds-2143-added comment

* feat(PPDSC-2143): chore-ppds-2143-added for open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants