-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ppdsc 2143 volume control horizontal expand #306
Merged
baburay23
merged 29 commits into
main
from
feat/PPDSC-2143-volume-control-horizontal-expand
Aug 9, 2022
Merged
Feat/ppdsc 2143 volume control horizontal expand #306
baburay23
merged 29 commits into
main
from
feat/PPDSC-2143-volume-control-horizontal-expand
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baburay23
requested review from
jps,
Xin00163,
pdimova,
mutebg,
Vanals,
evgenitsn and
Srinivasan-Ramasamy
as code owners
July 20, 2022 13:22
You can preview these changes on: |
Xin00163
reviewed
Aug 1, 2022
src/audio-player-composable/__tests__/audio-player-composable.stories.tsx
Outdated
Show resolved
Hide resolved
src/audio-player-composable/__tests__/audio-player-composable.stories.tsx
Show resolved
Hide resolved
mstuartf
reviewed
Aug 2, 2022
src/audio-player-composable/components/volume-control/volume-control.tsx
Show resolved
Hide resolved
Xin00163
approved these changes
Aug 8, 2022
mstuartf
approved these changes
Aug 9, 2022
mutebg
approved these changes
Aug 9, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
* feat(PPDSC-2143): chore-ppdse-2143-added expand * feat(PPDSC-2143): chore-ppdse-2143-added types * feat(PPDSC-2143): chore-ppdse-2143-layout options working * feat(PPDSC-2143): chore-ppdse-2143-tidied up * feat(PPDSC-2143): chore-ppdse-2143-transition ahrd coded * feat(PPDSC-2143): chore-ppdse-2143-added stories * feat(PPDSC-2143): chore-ppds-2143-motion working * feat(PPDSC-2143): chore-ppds-2143-horizonal working * feat(PPDSC-2143): chore-ppds-2143-added visible * feat(PPDSC-2143): chore-ppds-2143-tideid up * feat(PPDSC-2143): chore-ppds-2143-updated snapshots and sotires * feat(PPDSC-2143): chore-ppds-2143-added tests for styled.ts * feat(PPDSC-2143): chore-ppds-2143-tests 100% * feat(PPDSC-2143): chore-ppds-2143-updated stories * feat(PPDSC-2143): chore-ppds-2143-updated tests * feat(PPDSC-2143): chore-ppds-2143-removed comments * feat(PPDSC-2143): chore-ppds-2143-fixed aria-landmark * feat(PPDSC-2143): chore-ppds-2143-updated docs * feat(PPDSC-2143): chore-ppds-2143-addressed comments * feat(PPDSC-2143): chore-ppds-2143-added comment * feat(PPDSC-2143): chore-ppds-2143-added for open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2143
What
'horizontal' | 'horizontalCollapsed' | 'horizontalExpandable' | 'vertical'.
The default is 'horizontalExpandable'
. i have removed the old collapsed propWe also created a new transitionPreset 'widthChange' to apply transition to the expandable div. This is now also overridable by the user. I have also added in documentation for this transitionPreset and stories approved by design
http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2143-volume-control-horizontal-expand/storybook/?path=/story/newskit-light-audio-player-composable--audio-player-volume-control-layout
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: