Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2277): CircleCI not sending message on pipeline failures #277

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Vanals
Copy link
Contributor

@Vanals Vanals commented Jul 13, 2022

PPDSC-2277

What

Passed context to every Job so slack notify could access to the slack token

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the fix This change fixes a bug label Jul 13, 2022
@Vanals Vanals added the ready for review Please assist in getting this reviewed label Jul 13, 2022
@Vanals Vanals merged commit 8930bf4 into main Jul 13, 2022
@Vanals Vanals deleted the fix/PPDSC-2277-slack-token-not-served branch July 13, 2022 13:53
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants