Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PPDSC-2249): drop concurrency limit for components #255

Merged
merged 2 commits into from
Jul 4, 2022
Merged

feat(PPDSC-2249): drop concurrency limit for components #255

merged 2 commits into from
Jul 4, 2022

Conversation

jps
Copy link
Contributor

@jps jps commented Jul 4, 2022

PPDSC-2249

What

  1. Background - we were going over our applitools concurrency limit
  2. What did you do - reduce the limit for component runs

@github-actions github-actions bot added the feature This change contains a new feature label Jul 4, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2249-drop-applitools-concurrency-limit
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2249-drop-applitools-concurrency-limit/storybook

tbradbury
tbradbury approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@tbradbury tbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concurrency is set to 50 in applitools.config.js is that OK?

@jps
Copy link
Contributor Author

jps commented Jul 4, 2022

concurrency is set to 50 in applitools.config.js is that OK?

our limit is higher for full-page tests for some reason, ideally we would have the same for both as we use more components snapshots than full page

image

@jps jps merged commit 43d5612 into main Jul 4, 2022
@jps jps deleted the feat/PPDSC-2249-drop-applitools-concurrency-limit branch July 4, 2022 13:12
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
feat(PPDSC-2249): drop concurrency limit for components (#255)
81ea93e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenitsn evgenitsn evgenitsn approved these changes

@tbradbury tbradbury tbradbury approved these changes

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@mutebg mutebg Awaiting requested review from mutebg

@Vanals Vanals Awaiting requested review from Vanals

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
feature This change contains a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jps @newskit-engineering @evgenitsn @tbradbury