Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2095): add opacity tokens and gradients to the theme #202

Merged

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented May 17, 2022

PPDSC-2095

What

  • Added opacity and gradients tokens to the theme files.
  • Updated the style presets that were using hardcoded opacity values to tokens.

I have done:

  • Written functional tests against the component and/or NewsKit site
  • Written unit tests against changes
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed feature This change contains a new feature labels May 17, 2022
Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is not part of the ticket but there is 1 more place that uses opacity if you can update it as well src/theme/presets/transition-presets.ts
Apart from that ready to approve, everything looks good!

@evgenitsn
Copy link
Contributor Author

evgenitsn commented May 18, 2022

@mutebg Yes I was wondering whether we should update the transition-presets.ts as well but I wasn't sure.
I've now updated it.

@evgenitsn evgenitsn requested a review from mutebg May 18, 2022 08:15
@evgenitsn evgenitsn merged commit 742e934 into main May 19, 2022
@evgenitsn evgenitsn deleted the feat/PPDSC-2095-add-opacity-tokens-and-gradients-to-the-theme branch May 19, 2022 08:13
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* feat(PPDSC-2095): add opacity tokens and gradients to the theme

* feat(PPDSC-2095): updated transition-presets with opacity tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants