-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ppdsc 2113 prodtealium not being served #194
Conversation
You can preview these changes on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for explanation, seems good to me
* docs(PPDSC-0000): testing permissions * docs(PPDSC-0000): removing test changed from readme * fix(PPDSC-2113): testing vars * fix(PPDSC-2113): updated name * fix(PPDSC-2113): trying to make test job work * fix(PPDSC-2113): changing context to test * fix(PPDSC-2113): remove comments hoping t works * fix(PPDSC-2113): removed console.log * fix(PPDSC-2113): removed echo * fix(PPDSC-2113): testing * fix(PPDSC-2113): consologging stuff * fix(PPDSC-2113): debugging * fix(PPDSC-2113): static to initial props * fix(PPDSC-2113): nested props into props obj * fix(PPDSC-2113): to getStaticProps * fix(PPDSC-2113): console logging stuff * fix(PPDSC-2113): tealium with props and clog * fix(PPDSC-2113): removed static props - get var from process * fix(PPDSC-2113): cleaned _document file * fix(PPDSC-2113): added new line * fix(PPDSC-2113): added back pr env for job * fix(PPDSC-2113): improved naming var
PPDSC-2113
What
We were trying to access to
productionSiteEnv
throughthis.props
. this.props.productionSiteEnv is undefined.None of the props created at getStatiprops level were defined. The
production
prop, wasn't even used anywhere.I have so cleaned the props, removing production and productionSiteEnv, then questioned the rest of the function. If renderPage is needed or if getStaticProps is needed at all.
I am then accessing the values, directly from
process
without passing them as a prop(which wasn't happening anyway). Time ago when we were usinggetInitialProps
the props were working, but we moved away from it for fixing an issue with HeadNext.Removing the whole function
I could not find in the documentation any guidance around renderPage(), that could fit us, I could not find any guidance around why we should use getStaticProps in the _document. Instead, getStaticProps, is stated, is not supported in _document AND when building the page, after removing all of it, the website seems working fine.
https://nextjs.org/docs/advanced-features/custom-document
renderPage
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: