Skip to content

Commit

Permalink
fix(PPDSC-2797): remove CI installs of headless browsers (#609)
Browse files Browse the repository at this point in the history
* fix(PPDSC-2797): remove headless chrome

* fix(PPDSC-2797): change cypress image

* fix(PPDSC-2797): revert cypress image changes
  • Loading branch information
LukeFinch authored Feb 7, 2023
1 parent 2453981 commit 81076da
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 42 deletions.
35 changes: 3 additions & 32 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,18 +97,18 @@ executors:

node:
docker:
- image: cimg/node:16.13.0
- image: cimg/node:16.13.2-browsers

node-large:
docker:
- image: cimg/node:16.13.0
- image: cimg/node:16.13.2-browsers
resource_class: large
environment:
NODE_OPTIONS: --max_old_space_size=7680

node-xlarge:
docker:
- image: cimg/node:16.13.0
- image: cimg/node:16.13.2-browsers
resource_class: xlarge
environment:
NODE_OPTIONS: --max_old_space_size=15872
Expand Down Expand Up @@ -290,9 +290,6 @@ commands:
run_test_visual_comps_percy:
description: 'Run the Percy tests for comps visual changes'
steps:
- run:
name: Install Headless Chrome dependencies
command: make install_headless_chrome
- run:
name: Set percy/newskit-comps token
command: echo "export PERCY_TOKEN=${PERCY_COMPS_TOKEN}" >> $BASH_ENV
Expand All @@ -306,9 +303,6 @@ commands:
- checkout
- attach_workspace:
at: ~/project
- run:
name: Install Headless Chrome dependencies
command: make install_headless_chrome
- run:
name: Set percy/newskit-comps token
command: echo "export PERCY_TOKEN=${PERCY_COMPS_TOKEN}" >> $BASH_ENV
Expand Down Expand Up @@ -336,22 +330,6 @@ jobs:
- run:
name: 'Check to make sure all tests have run before merging.'
command: echo 'passed'

download_headless_chrome:
executor: node-large
steps:
- checkout
- run:
name: Download headless Chrome dependencies
command: make download_headless_chrome
- persist_to_workspace:
root: ./
paths:
- vendor/apt/*
- slack/notify:
<<: *slack_notify


install_deps:
executor: node-large
steps:
Expand Down Expand Up @@ -1234,7 +1212,6 @@ workflows:
jobs:
- install_deps
- install_cypress
- download_headless_chrome
- build_icons:
requires:
- install_deps
Expand Down Expand Up @@ -1318,7 +1295,6 @@ workflows:
context: ncu-product-platforms-context
requires:
- no_visual_changes
- download_headless_chrome
- skip_percy_docsite_check:
context: ncu-product-platforms-context
requires:
Expand All @@ -1327,7 +1303,6 @@ workflows:
context: ncu-product-platforms-context
requires:
- docs_and_comps_visual_changes
- download_headless_chrome
- test_visual_docs_percy:
context: ncu-product-platforms-context
requires:
Expand All @@ -1344,7 +1319,6 @@ workflows:
context: ncu-product-platforms-context
requires:
- docs_visual_changes
- download_headless_chrome
- can_i_merge_checker:
context: ncu-product-platforms-context
requires:
Expand Down Expand Up @@ -1454,8 +1428,6 @@ workflows:
- init_aws
- install_deps:
context: ncu-product-platforms-context
- download_headless_chrome:
context: ncu-product-platforms-context
- install_cypress:
context: ncu-product-platforms-context
- build_icons:
Expand Down Expand Up @@ -1517,7 +1489,6 @@ workflows:
- comps_tests_conditional_run_to_update_baselines:
context: ncu-product-platforms-context
requires:
- download_headless_chrome
- build_storybook
- docsite_tests_conditional_run_to_update_baselines:
context: ncu-product-platforms-context
Expand Down
10 changes: 0 additions & 10 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@ BASE_URI = ${SITE_BASE_URL}${BASE_PATH}/
install:
yarn install --frozen-lockfile

download_headless_chrome:
sudo apt-get update && sudo apt-get install --download-only -yq gconf-service libasound2 libatk1.0-0 libatk-bridge2.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 ca-certificates fonts-liberation libgbm-dev libappindicator1 libnss3 lsb-release xdg-utils wget
mkdir -p vendor/apt
sudo cp -R /var/cache/apt vendor/
sudo chown -R ${USER}:${USER} vendor/apt
sudo chmod -R 755 vendor/apt

install_headless_chrome:
sudo dpkg -i vendor/apt/archives/*.deb

# When changing the version, make sure it matches the one used in the `test_newskit_in_nextjs_app` CircleCI's job.
install_cypress:
yarn add -D cypress@12.3.0;
Expand Down

0 comments on commit 81076da

Please sign in to comment.