Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Dev-only sub-dependency bump of 'y18n' to clear npm audit warnings.
Bumped @grpc/grpc-js to ^1.2.11.
Bumped @grpc/proto-loader to ^0.5.6.
Agent no longer propagates segments for promises via async-hooks when the transaction associated with the parentSegment has ended.
This change reduces the amount of context tracking work needed for certain rare edge-case scenarios involving promises.
Fixed issue where capturing axios request errors could result in a memory leak.
The agent now clears error references on transaction end, which are not used for later processing. Errors returned from 'axios' requests contain a reference to the request object which deeper down has a handle to a promise in
handleRequestError
. The TraceSegment associated with that promise has a handle to the transaction, which through the error capture ultimately kept the promise in memory and prevented it from being destroyed to free-up the TraceSegment from the segment map. This change also has the benefit of freeing up some memory early for transactions held onto for transaction traces.Added active transaction check to
wrappedResEnd
to prevent unecessary work for ended transactions in the case of multipleResponse.prototype.end()
invocations.Links
Details