config index fix #1417
Merged
config index fix #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
force-pushed
the
config-index-fix
branch
from
ade0dee
to
7e9913b
Compare
bizob2828
commented
Nov 15, 2022
…lex essentially by breaking the functions down further. Updated all jsdoc to be compliant with linter.
bizob2828
force-pushed
the
config-index-fix
branch
from
7e9913b
to
a35867a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
+ Coverage 92.53% 92.56% +0.02%
==========================================
Files 175 175
Lines 35610 35671 +61
Branches 23 23
==========================================
+ Hits 32951 33018 +67
+ Misses 2659 2653 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jmartin4563
suggested changes
Nov 16, 2022
Co-authored-by: Jessica Lopatta <jlopatta@newrelic.com>
|
jmartin4563
previously approved these changes
Nov 17, 2022
jmartin4563
approved these changes
Nov 17, 2022
This was referenced Dec 5, 2022
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Links
Closes NEWRELIC-5278
Details
Extracted pieces of logic into their own functions to make certain functions less complex. I also bumped our
ecmaVersionin eslint to 2020 as Node.js 14 is 95% compliant. The only thing it does not support is spread parameters after optional chaining. I think we will be safe but I can dig into specifically not allowing this.