refactor: Replaced instances of substr() with substring() (#2274)

api.js

@@ -807,7 +807,7 @@ API.prototype.getBrowserTimingHeader = function getBrowserTimingHeader(options =
      * Only the first 13 chars of the license should be used for hashing with
      * the transaction name.
      */
-    const key = config.license_key.substr(0, 13)
+    const key = config.license_key.substring(0, 13)
     rumHash.transactionName = hashes.obfuscateNameUsingKey(name, key)
 
     rumHash.queueTime = trans.queueTime

bin/create-docs-pr.js

@@ -241,7 +241,7 @@ function formatReleaseNotes(releaseDate, version, body, frontmatter) {
     '---',
     'subject: Node.js agent',
     `releaseDate: '${releaseDate}'`,
-    `version: ${version.substr(1)}`, // remove the `v` from start of version
+    `version: ${version.substring(1)}`, // remove the `v` from start of version
     `downloadLink: 'https://www.npmjs.com/package/newrelic'`,
     `security: ${frontmatter.security}`,
     `bugs: ${frontmatter.bugfixes}`,
@@ -279,7 +279,7 @@ function addReleaseNotesFile(body, version) {
 
 function getFileName(version) {
   // change `v0.0.0` to `0-0-0`
-  version = version.substr(1).replace(/\./g, '-')
+  version = version.substring(1).replace(/\./g, '-')
   const FILE = `node-agent-${version}.mdx`
   return `${RELEASE_NOTES_PATH}/${FILE}`
 }

lib/config/attribute-filter.js

@@ -367,7 +367,7 @@ function _convertRulesToRegex(rules) {
           if (i !== r.length - 1) {
             v += '.'
           } else if (/\\\*$/.test(v)) {
-            v = v.substr(0, v.length - 2)
+            v = v.substring(0, v.length - 2)
           }
 
           const idx = c.findIndex(function findV(a) {

lib/instrumentation/aws-sdk/util.js

@@ -14,7 +14,7 @@ function grabLastUrlSegment(url = '/') {
   // string for null, undefined, NaN etc.
   url = '' + (url || '/')
   const lastSlashIndex = url.lastIndexOf('/')
-  return url.substr(lastSlashIndex + 1)
+  return url.substring(lastSlashIndex + 1)
 }
 
 /**

lib/shim/datastore-shim.js

@@ -376,10 +376,10 @@ function parseQuery(query, nodule) {
   // strip enclosing special characters from collection (table) name
   if (typeof collection === 'string' && collection.length > 2) {
     if (/^[\[{'"`]/.test(collection)) {
-      collection = collection.substr(1)
+      collection = collection.substring(1)
     }
     if (/[\]}'"`]$/.test(collection)) {
-      collection = collection.substr(0, collection.length - 1)
+      collection = collection.substring(0, collection.length - 1)
     }
   }
 

lib/transaction/name-state.js

@@ -187,7 +187,7 @@ NameState.prototype.getPath = function getPath() {
       if (a[0] !== '/' && path[path.length - 1] !== '/') {
         path += '/'
       } else if (a[0] === '/' && path[path.length - 1] === '/') {
-        a = a.substr(1)
+        a = a.substring(1)
       }
       path += a
     }

lib/util/hashes.js

@@ -41,7 +41,8 @@ function calculatePathHash(appName, pathName, referingPathHash) {
   const result = (rotated ^ hash) >>> 0
 
   // This is a trick to pad it out to 8 chars regardless of length.
-  return ('00000000' + result.toString(16)).substr(-8)
+  const str = '00000000' + result.toString(16)
+  return str.substring(str.length - 8)
 }
 
 function getHash(appName, txName) {
@@ -78,7 +79,7 @@ function int32ToByteArray(int32) {
 // Lookup table for converting byte values to hex
 const byteToHex = []
 for (let i = 0; i < 256; ++i) {
-  byteToHex[i] = (i + 0x100).toString(16).substr(1)
+  byteToHex[i] = (i + 0x100).toString(16).substring(1)
 }
 
 function makeId(length = 16) {

lib/utilization/docker-info.js

@@ -41,7 +41,7 @@ module.exports.getBootId = function getBootId(agent, callback) {
     if (data.length !== 36) {
       bootIdError()
       if (data.length > 128) {
-        data = data.substr(0, 128)
+        data = data.substring(0, 128)
       }
     }
 

lib/utilization/gcp-info.js

@@ -54,8 +54,10 @@ function fetchGCPInfo(agent, callback) {
         agent.metrics.getOrCreateMetric(NAMES.UTILIZATION.GCP_ERROR).incrementCallCount()
       } else {
         // normalize
-        results.machineType = results.machineType.substr(results.machineType.lastIndexOf('/') + 1)
-        results.zone = results.zone.substr(results.zone.lastIndexOf('/') + 1)
+        results.machineType = results.machineType.substring(
+          results.machineType.lastIndexOf('/') + 1
+        )
+        results.zone = results.zone.substring(results.zone.lastIndexOf('/') + 1)
 
         resultDict = results
       }

test/integration/instrumentation/http-rum.tap.js

@@ -56,14 +56,14 @@ test('custom naming rules should be applied early for RUM', function (t) {
     function done(res) {
       res.pipe(
         new StreamSink(function (err, header) {
-          t.equal(header.substr(0, 7), '<script', 'should generate RUM headers')
+          t.equal(header.substring(0, 7), '<script', 'should generate RUM headers')
           header.split(';').forEach(function (element) {
-            if (element.substr(0, DATA_PREFIX.length) === DATA_PREFIX) {
-              const dataString = element.substr(DATA_PREFIX.length, element.length)
+            if (element.substring(0, DATA_PREFIX.length) === DATA_PREFIX) {
+              const dataString = element.substring(DATA_PREFIX.length, element.length)
               const data = JSON.parse(dataString)
               const tx = hashes.deobfuscateNameUsingKey(
                 data.transactionName,
-                agent.config.license_key.substr(0, 13)
+                agent.config.license_key.substring(0, 13)
               )
               t.equal(tx, 'WebTransaction/NormalizedUri/WORKING', 'should normalize url before RUM')
             }
@@ -106,14 +106,14 @@ test('custom web transactions should have rules applied for RUM', function (t) {
 
   api.startWebTransaction('/test', function () {
     const header = api.getBrowserTimingHeader()
-    t.equal(header.substr(0, 7), '<script', 'should generate RUM headers')
+    t.equal(header.substring(0, 7), '<script', 'should generate RUM headers')
     header.split(';').forEach(function (element) {
-      if (element.substr(0, DATA_PREFIX.length) === DATA_PREFIX) {
-        const dataString = element.substr(DATA_PREFIX.length, element.length)
+      if (element.substring(0, DATA_PREFIX.length) === DATA_PREFIX) {
+        const dataString = element.substring(DATA_PREFIX.length, element.length)
         const data = JSON.parse(dataString)
         const tx = hashes.deobfuscateNameUsingKey(
           data.transactionName,
-          agent.config.license_key.substr(0, 13)
+          agent.config.license_key.substring(0, 13)
         )
         t.equal(tx, 'WebTransaction/NormalizedUri/WORKING', 'url normalized before RUM')
       }

test/unit/rum.test.js

@@ -230,7 +230,7 @@ tap.test('the RUM API', function (t) {
       t.ok(payload)
       const deobf = hashes.deobfuscateNameUsingKey(
         payload[1],
-        agent.config.license_key.substr(0, 13)
+        agent.config.license_key.substring(0, 13)
       )
       t.equal(JSON.parse(deobf).u.hello, 1)
       t.end()

test/versioned/express/render.tap.js

@@ -234,7 +234,7 @@ function runTests(conf) {
 
       app.get(TEST_PATH, function (req, res) {
         const rum = api.getBrowserTimingHeader()
-        t.equal(rum.substr(0, 7), '<script')
+        t.equal(rum.substring(0, 7), '<script')
         res.render('index', { title: 'yo dawg', rum: rum })
       })
 

test/versioned/hapi/render.tap.js

@@ -146,7 +146,7 @@ tap.test('agent instrumentation of Hapi', function (t) {
       path: '/test',
       handler: function (req, h) {
         const rum = api.getBrowserTimingHeader()
-        t.equal(rum.substr(0, 7), '<script')
+        t.equal(rum.substring(0, 7), '<script')
         return h.view('index', { title: 'yo dawg', rum: rum })
       }
     })

test/versioned/restify/pre-7/rum.tap.js

@@ -29,7 +29,7 @@ tap.test('Restify router introspection', function (t) {
 
   server.get('/test/:id', function (req, res, next) {
     const rum = api.getBrowserTimingHeader()
-    t.equal(rum.substr(0, 7), '<script')
+    t.equal(rum.substring(0, 7), '<script')
     res.send({ status: 'ok' })
     next()
   })

test/versioned/restify/rum.tap.js

@@ -29,7 +29,7 @@ tap.test('Restify router introspection', function (t) {
 
   server.get('/test/:id', function (req, res, next) {
     const rum = api.getBrowserTimingHeader()
-    t.equal(rum.substr(0, 7), '<script')
+    t.equal(rum.substring(0, 7), '<script')
     res.send({ status: 'ok' })
     next()
   })