Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the consistency for the capitalization of 'Agent' -> 'agent' across the project #2295

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fixes the consistency for the capitalization of 'Agent' -> 'agent' across the project #2295

merged 2 commits into from
Nov 1, 2023

Conversation

dinsley
Copy link
Contributor

@dinsley dinsley commented Oct 27, 2023

This fixes the consistent usage of the word 'Agent' to 'agent' across the project that is outlined in the issue opened here:

#1118

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Oct 27, 2023
kaylareopelle
kaylareopelle reviewed Oct 28, 2023
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Thank you! I think we have a few small things to change before it's ready to go.

lib/new_relic/agent/worker_loop.rb Outdated Show resolved Hide resolved
lib/new_relic/agent/event_loop.rb Outdated Show resolved Hide resolved
init.rb
@@ -12,7 +12,7 @@
# If you can't find any log files and you don't see anything in your
# application log files please visit support.newrelic.com.

# Initializer for the NewRelic Ruby Agent
# Initializer for the New Relic Ruby agent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

newrelic.yml Outdated Show resolved Hide resolved
newrelic.yml Show resolved Hide resolved
lib/new_relic/agent/attribute_filter.rb Outdated Show resolved Hide resolved
lib/new_relic/agent/attribute_filter.rb Show resolved Hide resolved
@dinsley
Copy link
Contributor Author

dinsley commented Oct 31, 2023

Will go through and fix this one up this evening!

@dinsley
Copy link
Contributor Author

dinsley commented Oct 31, 2023

should be g2g for another review pass now :)

kaylareopelle
kaylareopelle approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your help, @dinsley! 🚀

@kaylareopelle kaylareopelle merged commit cb72bb5 into newrelic:dev Nov 1, 2023
25 checks passed
@hannahramadan hannahramadan mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@fallwith fallwith Awaiting requested review from fallwith fallwith is a code owner

@hannahramadan hannahramadan Awaiting requested review from hannahramadan hannahramadan is a code owner

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
community To tag external issues and PRs submitted by the community hacktoberfest-accepted
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinsley @kaylareopelle