Skip to content

Add giveup_early to get_package_version functions - #868

Closed
hmstepanek wants to merge 1 commit into
mainfrom
fix-version-performance-issues
Closed

Add giveup_early to get_package_version functions#868
hmstepanek wants to merge 1 commit into
mainfrom
fix-version-performance-issues

Conversation

@hmstepanek

@hmstepanek hmstepanek commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

Overview

Add giveup_early to get_package_version functions and only get version once at import time.

Related Github Issue

This is a fix for #817.

@github-actions

github-actions Bot commented Jul 12, 2023

Copy link
Copy Markdown

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 4 0 5.9s
✅ PYTHON black 4 0 0 0.88s
✅ PYTHON flake8 4 0 0.52s
✅ PYTHON isort 4 0 0 0.24s
✅ PYTHON pylint 4 0 3.43s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify Bot added the tests-failing Tests failing in CI. label Jul 12, 2023
@codecov-commenter

codecov-commenter commented Jul 12, 2023

Copy link
Copy Markdown

Codecov Report

Merging #868 (4d4db82) into main (6644846) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
- Coverage   81.13%   81.11%   -0.03%     
==========================================
  Files         183      183              
  Lines       18251    18255       +4     
  Branches     3160     3161       +1     
==========================================
- Hits        14808    14807       -1     
- Misses       2585     2588       +3     
- Partials      858      860       +2     
Impacted Files Coverage Δ
newrelic/hooks/datastore_aioredis.py 58.49% <66.66%> (ø)
newrelic/common/package_version_utils.py 97.87% <100.00%> (+0.09%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hmstepanek
hmstepanek force-pushed the fix-version-performance-issues branch 5 times, most recently from 80258cf to bee9a45 Compare July 14, 2023 17:17
@hmstepanek
hmstepanek force-pushed the fix-version-performance-issues branch from bee9a45 to 4d4db82 Compare July 14, 2023 17:18
@mergify mergify Bot removed the tests-failing Tests failing in CI. label Jul 14, 2023
@mergify mergify Bot added the merge-conflicts Merge conflicts detected. label Aug 10, 2023
@hmstepanek hmstepanek closed this Oct 16, 2023
@mergify mergify Bot removed the merge-conflicts Merge conflicts detected. label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants