Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphene-Django introspection fix #656

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Graphene-Django introspection fix #656

wants to merge 34 commits into from

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Oct 10, 2022 •
edited by hmstepanek
Loading

This PR adds:

  1. Instrumentation for graphene-django
  2. A fix to the user seeing an introspection field (__schema) after loading/reloading a GraphiQL page while running New Relic.

lrafeei and others added 22 commits March 24, 2022 14:38
@lrafeei
Add GraphQL Server Sanic Instrumentation
1bdf3b1
@lrafeei
Co-authored-by: Timothy Pansino <TimPansino@users.noreply.github.com>
9e526d1 
Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
@lrafeei @TimPansino @umaannamalai
Add co-authors
9f8856b 
Co-authored-by: Timothy Pansino <TimPansino@users.noreply.github.com>
Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
@lrafeei @TimPansino @umaannamalai
Comment out Copyright notice message
375bda5 
Co-authored-by: Timothy Pansino <TimPansino@users.noreply.github.com>
Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
@TimPansino
Finalize Sanic testing
07ec74f
@TimPansino
Fix flask framework details with callable
f781423
@TimPansino
Parametrized testing for graphql-server
58418ee
@TimPansino @lrafeei @umaannamalai
GraphQL Async Resolvers
215538b 
Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
@TimPansino
Merge branch 'main' into develop-graphql-async
e7705ad
@TimPansino
Merge branch 'main' into develop-graphql-async
38e9f72
@TimPansino
GraphQL Proper Coro and Promise Support (#508)
8cda4f7 
* Fix GraphQL async issues

* Fix nonlocal binding issues in python 2

* Fix promises with async graphql

* Issues with promises

* Fix promises in graphql2

* Fixed all graphql async issues

* Fix Py27 quirks

* Update tox

* Fix importing paths of graphqlserver

* Fix broken import path

* Unpin pypy37

* Fix weird import issues
@TimPansino
Merge branch 'main' into develop-graphql-async
7c630b8
@TimPansino
Fix graphql impl coros (#522)
56cab4b
@TimPansino
Strawberry Async Updates (#521)
fd57192 
* Parameterize strawberry tests

* Remove duplicate functions

* Fix strawberry version testing

* Updates

* Finalize strawberry updates

* Clean out code
@TimPansino
Ariadne Async Testing (#523)
ff9b1b4 
* Parameterize ariadne tests

* Fixing ariadne tests

* Fixing ariadne middleware

* Set 0 extra spans for graphql core tests

* Add spans attr to strawberry tests
@TimPansino
Graphene Async Testing (#524)
a2889a6 
* Graphene Async Testing

* Fix missing extra spans numbers

* Graphene promise tests

* Fix py2 imports

* Removed unused __init__

* Update code level metrics validator for py2

* Unify graphql testing imports

* Fix ariadne imports

* Fix other imports

* Fix import issues
@TimPansino
Merge branch 'main' into develop-graphql-async
addc9e5
@TimPansino
Merge branch 'main' into develop-graphql-async
ec0ec2f
@TimPansino
Merge branch 'main' into develop-graphql-async
545fdfa
@TimPansino
Merge branch 'main' into develop-graphql-async
61d32f1
@TimPansino
Merge branch 'main' into develop-graphql-async
619026e
@lrafeei
Catch GraphiQL reload to introspection
5b3693e
@github-actions
Copy link

github-actions bot commented Oct 10, 2022 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 3 0 3.02s
✅ PYTHON black 13 0 0 1.35s
✅ PYTHON flake8 13 0 0.89s
✅ PYTHON isort 13 0 0 0.22s
✅ PYTHON pylint 13 0 8.25s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

lrafeei and others added 7 commits October 18, 2022 12:38
@lrafeei
Instrument graphene_django framework
34209bc
@lrafeei
Add tests in .tox file
6dfbc02
@lrafeei
Temporarily remove graphene_django tests from tox.ini
1bf2071
@lrafeei
Add initial test setup for graphene-django
5b67b3a
@lrafeei @TimPansino
Initial test commit for graphene-django
7c2c396 
Co-authored-by: Timothy Pansino <TimPansino@users.noreply.github.com>
@lrafeei
Imported graphene tests into graphene-django tests
8aa9de8 
<TimPansino@users.noreply.github.com>Co-authored-by: Timothy Pansino
@lrafeei @TimPansino
@hmstepanek @umaannamalai
Fix testing/account for existing GraphQLOperationTrace creation
1b52d49 
Co-authored-by: Timothy Pansino <TimPansino@users.noreply.github.com>
Co-authored-by: Hannah Stepanek <hmstepanek@users.noreply.github.com>
Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
@hmstepanek hmstepanek marked this pull request as ready for review November 7, 2022 19:17
@hmstepanek hmstepanek requested a review from a team November 7, 2022 19:17
hmstepanek
hmstepanek previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one request for a comment otherwise looks good! I'm just gonna pre-approve this.

newrelic/hooks/framework_graphql.py Show resolved Hide resolved
tests/component_graphenedjango/wsgi.py Show resolved Hide resolved
@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 7, 2023
Base automatically changed from develop-graphql-async to main August 28, 2023 19:26
@stale stale bot removed the stale label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmstepanek hmstepanek hmstepanek left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
merge-conflicts tests-failing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lrafeei @hmstepanek @TimPansino