Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 Support #1226

Merged
merged 10 commits into from
Oct 8, 2024
Merged

Python 3.13 Support #1226

merged 10 commits into from
Oct 8, 2024

Conversation

TimPansino
Copy link
Contributor

Overview

  • Add wheels and classifiers for Python 3.13.
    • Update cibuildwheel to use a version with Python 3.13 support.
  • Add support for setuptools_scm v7 & v8 for Python 3.13 compatibility.
  • Add Python 3.13 to all relevant tox matrices.
    • Add annotated and commented out environments where Python 3.13 is not yet supported by the library. Can be uncommented again to test in the next few weeks as more wheels become available, and should eventually be slotted into the existing matrix line.
  • Update C Extensions to work with Python 3.13, and remove Python 2 macros.
  • Fix broken tests for agent_unittests in developer mode.
  • Fix broken metric across all memcache tests expecting too strict a localhost hostname.

@TimPansino TimPansino requested a review from a team as a code owner October 2, 2024 20:31
Copy link

github-actions bot commented Oct 2, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.88s
✅ PYTHON black 5 2 0 1.02s
❌ PYTHON flake8 5 1 0.51s
✅ PYTHON isort 5 3 0 0.29s
✅ PYTHON pylint 5 0 4.0s
✅ YAML prettier 1 0 0 0.49s
✅ YAML v8r 1 0 2.22s
✅ YAML yamllint 1 0 0.28s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (1807857) to head (d34601b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
- Coverage   81.27%   81.23%   -0.04%     
==========================================
  Files         197      197              
  Lines       21643    21643              
  Branches     3782     3782              
==========================================
- Hits        17590    17582       -8     
- Misses       2913     2918       +5     
- Partials     1140     1143       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hmstepanek
hmstepanek previously approved these changes Oct 3, 2024
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple feedback comments.

tests/agent_unittests/test_full_uri_payloads.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@@ -231,13 +252,12 @@ deps =
component_tastypie-tastypielatest: django-tastypie
component_tastypie-tastypielatest: django<4.1
component_tastypie-tastypielatest: asgiref<3.7.1 # asgiref==3.7.1 only suppport Python 3.10+
coroutines_asyncio-{py37,py38,py39,py310,py311,py312}: uvloop
coroutines_asyncio-{py37,py38,py39,py310,py311,py312,py313}: uvloop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was py313 meant to be added here? This isn't being tested on 3.13 above due to the uvloop dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added for when we enable the actual tox environment in the future.

@mergify mergify bot removed the tests-failing label Oct 8, 2024
Copy link
Contributor

@umaannamalai umaannamalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@TimPansino TimPansino merged commit 3a001b0 into main Oct 8, 2024
52 of 53 checks passed
@TimPansino TimPansino deleted the feature-python313 branch October 8, 2024 17:42
@TimPansino TimPansino added this to the 10.1.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants