-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.13 Support #1226
Python 3.13 Support #1226
Conversation
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
==========================================
- Coverage 81.27% 81.23% -0.04%
==========================================
Files 197 197
Lines 21643 21643
Branches 3782 3782
==========================================
- Hits 17590 17582 -8
- Misses 2913 2918 +5
- Partials 1140 1143 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple feedback comments.
@@ -231,13 +252,12 @@ deps = | |||
component_tastypie-tastypielatest: django-tastypie | |||
component_tastypie-tastypielatest: django<4.1 | |||
component_tastypie-tastypielatest: asgiref<3.7.1 # asgiref==3.7.1 only suppport Python 3.10+ | |||
coroutines_asyncio-{py37,py38,py39,py310,py311,py312}: uvloop | |||
coroutines_asyncio-{py37,py38,py39,py310,py311,py312,py313}: uvloop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was py313
meant to be added here? This isn't being tested on 3.13 above due to the uvloop
dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added for when we enable the actual tox environment in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Overview