Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Artifact Actions to Newer Versions #1125

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Update Artifact Actions to Newer Versions #1125

merged 5 commits into from
Apr 16, 2024

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Apr 16, 2024

Overview

  • Update artifact upload/download actions to latest version to fix issues with new Github functionality breaking existing actions.
  • Update code coverage action after previous version was deprecated
    • Add required security token for new version to function
  • Add missing firestore dependency graph link for code coverage action

Copy link

github-actions bot commented Apr 16, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ YAML prettier 1 1 0 0.76s
✅ YAML v8r 1 0 1.91s
✅ YAML yamllint 1 0 0.33s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (6fd639d) to head (1cd2400).
Report is 323 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   81.15%   81.76%   +0.61%     
==========================================
  Files         190      192       +2     
  Lines       19747    21303    +1556     
  Branches     3468     3707     +239     
==========================================
+ Hits        16025    17418    +1393     
- Misses       2732     2809      +77     
- Partials      990     1076      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the tests-failing label Apr 16, 2024
@TimPansino TimPansino marked this pull request as ready for review April 16, 2024 21:48
@TimPansino TimPansino requested a review from a team April 16, 2024 21:48
@TimPansino TimPansino merged commit 649044c into main Apr 16, 2024
48 of 49 checks passed
@TimPansino TimPansino deleted the fix-coverage branch April 16, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants