-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agent): Add supportability metrics for packages that provide major version #868
Conversation
I think all versions of Guzzle and Monolog will give you a major version. Probably other frameworks potentially will give us just major info. |
|
Good point, I have added supportability metrics for Guzzle and Monolog by major version also: 5248b97 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #868 +/- ##
==========================================
- Coverage 78.76% 78.73% -0.04%
==========================================
Files 193 193
Lines 27125 27154 +29
==========================================
+ Hits 21365 21379 +14
- Misses 5760 5775 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR creates a new supportability metric that will provide information on what major version of the package is being used. The packages that provide the major version and will send up this supportability metric are: