update NEW_RELIC_ENABLED to Env bool (#234)

* add ParseBool for env var
newrelic · Sep 16, 2024 · ac7ad99 · ac7ad99
1 parent 2081151
commit ac7ad99
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/config/config.go b/config/config.go
@@ -57,8 +57,11 @@ func ConfigurationFromEnvironment() *Configuration {
 	collectTraceIDStr, collectTraceIDOverride := os.LookupEnv("NEW_RELIC_COLLECT_TRACE_ID")
 
 	extensionEnabled := true
-	if nrEnabledOverride && strings.ToLower(nrEnabledStr) == "false" {
-		extensionEnabled = false
+	if nrEnabledOverride {
+		b, err := strconv.ParseBool(nrEnabledStr)
+		if err == nil && !b {
+			extensionEnabled = false
+		}
 	}
 	if nrEnabledRubyOverride && strings.ToLower(nrEnabledRubyStr) == "false" {
 		extensionEnabled = false

diff --git a/config/config_test.go b/config/config_test.go
@@ -83,6 +83,14 @@ func TestConfigurationFromEnvironmentNREnabled(t *testing.T) {
 	assert.Equal(t, conf.ExtensionEnabled, false)
 }
 
+func TestConfigurationFromEnvironmentNREnabledBool(t *testing.T) {
+	os.Setenv("NEW_RELIC_ENABLED", "0")
+	defer os.Unsetenv("NEW_RELIC_ENABLED")
+
+	conf := ConfigurationFromEnvironment()
+	assert.Equal(t, conf.ExtensionEnabled, false)
+}
+
 func TestConfigurationFromEnvironmentNRAgentEnabled(t *testing.T) {
 	os.Setenv("NEW_RELIC_AGENT_ENABLED", "false")
 	defer os.Unsetenv("NEW_RELIC_AGENT_ENABLED")