Update to support v24 of graphql #2425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #2301
It seems that the only change to support v24+ of graphql is to update the method call on the FieldValueInfo instance. The
getFieldValuemethod was marked for deprecation in v22 and removed in v24. The replacement call isgetFieldValueFuturewhich still returns aCompletableFuture, although the generic typing changed.Note that the verification explicitly skips v23.x since this was marked as "Do not use" by the maintainers.
https://github.com/graphql-java/graphql-java/releases/tag/v23.0