Skip to content

Conversation

@jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Jul 15, 2025

Overview

Resolves #2301

It seems that the only change to support v24+ of graphql is to update the method call on the FieldValueInfo instance. The getFieldValue method was marked for deprecation in v22 and removed in v24. The replacement call is getFieldValueFuture which still returns a CompletableFuture, although the generic typing changed.

Note that the verification explicitly skips v23.x since this was marked as "Do not use" by the maintainers.
https://github.com/graphql-java/graphql-java/releases/tag/v23.0

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.50%. Comparing base (6bf1981) to head (b045302).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2425   +/-   ##
=========================================
  Coverage     70.49%   70.50%           
- Complexity    10041    10042    +1     
=========================================
  Files           845      845           
  Lines         40693    40693           
  Branches       6171     6171           
=========================================
+ Hits          28687    28689    +2     
+ Misses         9214     9212    -2     
  Partials       2792     2792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtduffy jtduffy moved this from Triage to Needs Review in Java Engineering Board Jul 17, 2025
@jtduffy jtduffy merged commit e97b02d into main Jul 17, 2025
328 of 333 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Code Complete/Done in Java Engineering Board Jul 17, 2025
@jtduffy jtduffy deleted the graphql24-support branch July 17, 2025 14:34
@kmudduluru kmudduluru moved this to Code Complete/Done in Java Engineering Board Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add instrumentation for GraphQL 24+

4 participants