Skip to content

Conversation

@jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Mar 18, 2025

Overview

Refactor the code used to fetch the AWS Fargate docker ID to use URLConnection, which allows a sane timeout value to be assigned for the connect sequence.

Resolves #2247

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.54%. Comparing base (83666de) to head (8b4eaad).

Files with missing lines Patch % Lines
...c/agent/utilization/AwsFargateMetadataFetcher.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2275      +/-   ##
============================================
- Coverage     70.54%   70.54%   -0.01%     
- Complexity    10021    10022       +1     
============================================
  Files           844      844              
  Lines         40569    40572       +3     
  Branches       6148     6148              
============================================
+ Hits          28618    28620       +2     
- Misses         9169     9171       +2     
+ Partials       2782     2781       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtduffy jtduffy merged commit 667a598 into main Mar 18, 2025
111 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Java Engineering Board Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Null pointer during getting docker id from fargate metadata when start up

4 participants