Skip to content

Conversation

@obenkenobi
Copy link
Contributor

Overview

The default start point for starting netty HTTP2 transactions were reverted to use io.netty.handler.codec.http2.Http2FrameCodec. This will stop the 'unknown' http2 transactions at a loss possible coverage of http2 requests in niche scenarios. To add such granularity at the cost of possibly receiving 'unknown', a new feature flag is added via the config:

common: &default_settings
...
  netty:
    http2:
      frame_read_listener:
        start_transaction: true

Related Github Issue

#2106

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (0f181db) to head (3d6f5af).
Report is 46 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2274      +/-   ##
============================================
- Coverage     70.60%   70.54%   -0.06%     
- Complexity     9995    10023      +28     
============================================
  Files           843      844       +1     
  Lines         40453    40572     +119     
  Branches       6130     6148      +18     
============================================
+ Hits          28562    28622      +60     
- Misses         9112     9171      +59     
  Partials       2779     2779              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jtduffy
jtduffy previously approved these changes Mar 18, 2025
@obenkenobi obenkenobi merged commit 7bfd208 into main Mar 21, 2025
111 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Java Engineering Board Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants