Skip to content

Conversation

@meiao
Copy link
Contributor

@meiao meiao commented Jan 14, 2025

Overview

Kafka Clients 3.9 changed the name of a class which made our instrumentation incompatible.

This PR adds new instrumentation modules, kafka-clients-metrics-3.9 and kafka-clients-node-metrics-3.9 which are almost identical to their 3.7 counterparts, except for the changed class name.

Related Github Issue

Closes #2131

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.56%. Comparing base (2c2422a) to head (9af72b6).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2203      +/-   ##
============================================
+ Coverage     70.54%   70.56%   +0.01%     
  Complexity     9974     9974              
============================================
  Files           842      842              
  Lines         40369    40369              
  Branches       6118     6118              
============================================
+ Hits          28480    28486       +6     
+ Misses         9110     9105       -5     
+ Partials       2779     2778       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jtduffy
jtduffy previously approved these changes Jan 15, 2025
@meiao meiao merged commit aa608ee into main Jan 15, 2025
114 checks passed
@meiao meiao deleted the kafka-3.9 branch January 15, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for kafka-clients-metrics 3.9.0+

4 participants