Instrumentation module for Struts2 v6.7.0 #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2199 +/- ##
============================================
- Coverage 70.58% 70.55% -0.04%
Complexity 9975 9975
============================================
Files 842 842
Lines 40367 40369 +2
Branches 6117 6118 +1
============================================
- Hits 28494 28483 -11
- Misses 9096 9108 +12
- Partials 2777 2778 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meiao
reviewed
Jan 14, 2025
settings.gradle
Outdated
| include 'instrumentation:apache-pekko-http-3_1' | ||
| include 'instrumentation:apache-pekko-http-core-2.13_1' | ||
| include 'instrumentation:apache-struts-2.0' | ||
| include 'instrumentation:apache-struts-2.0_6.7.0' |
Contributor
There was a problem hiding this comment.
any reason to not name this module apache-struts-6.7.0?
Contributor
Author
There was a problem hiding this comment.
Only because we named the original module apache-struts-2.0 (which was my mistake).
I'm actually fine renaming this module and the original struts2 module if everyone else is ok with it.
meiao
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
New module to support Struts2 v6.7.0 and greater. Mainly package name refactoring in Struts2.
Related Github Issue
Resolves #2158