Skip to content

Conversation

@dhilpipre
Copy link
Collaborator

Overview

When the Java Agent attempts to read headers from io.grpc.netty.GrpcHttp2HeadersUtils.GrpcHttp2RequestHeaders it throws an exception because the get method expects an io.netty.util.AsciiString input but receives a String from the agent.

Related Github Issue

This fixes
#2177

This code check to see if the Http2Headers class that is passed into the constructor for com.agent.instrumentation.netty4116.Http2RequestHeaderWrapper is GrpcHttp2RequestHeaders. If it is it sets a flag.
In both the getHeader and getHeaders methods, it checks if the GRPC flag is set and if true then creates an AsciiString to use.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jtduffy jtduffy merged commit f0f8e55 into newrelic:main Dec 23, 2024
138 of 143 checks passed
@dhilpipre dhilpipre deleted the fix_grpc_netty branch April 2, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants