Add optional attributes for recordError #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in optional attributes
ndesai-newrelic
approved these changes
Jul 14, 2023
ndesai-newrelic
pushed a commit
that referenced
this pull request
Jul 20, 2023
* feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes
ndesai-newrelic
added a commit
that referenced
this pull request
Jul 21, 2023
* Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * 1)Fixes the issue where the response body appears empty for HTTP requests. 2) Upgraded native Android agent to v7.0.0 * 1)Fixes the issue where the response body appears empty for HTTP requests. 2) Upgraded native Android agent to v7.0.0 --------- Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com>
ndesai-newrelic
added a commit
that referenced
this pull request
Jul 26, 2023
* Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Update update_agent_version.yml --------- Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com>
ndesai-newrelic
added a commit
that referenced
this pull request
Jul 26, 2023
* Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Update iOS agent to 7.4.6 (#73) * Update iOS Version to 7.4.6 * Release 6.2.3 --------- Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com> Co-authored-by: ndesai-newrelic <89222514+ndesai-newrelic@users.noreply.github.com> --------- Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com>
ndesai-newrelic
pushed a commit
that referenced
this pull request
Feb 13, 2024
* feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes
ndesai-newrelic
pushed a commit
that referenced
this pull request
Feb 13, 2024
* feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes
ndesai-newrelic
added a commit
that referenced
this pull request
Feb 20, 2024
* Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Update iOS agent to 7.4.6 (#73) * Update iOS Version to 7.4.6 * Release 6.2.3 --------- Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com> Co-authored-by: ndesai-newrelic <89222514+ndesai-newrelic@users.noreply.github.com> * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * resolve merge conflicts with master * fix fetch instrumentation bugs --------- Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com>
ndesai-newrelic
pushed a commit
that referenced
this pull request
Mar 5, 2024
* feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes
ndesai-newrelic
pushed a commit
that referenced
this pull request
Mar 5, 2024
* feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes
ndesai-newrelic
pushed a commit
that referenced
this pull request
Mar 5, 2024
* feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes
ndesai-newrelic
added a commit
that referenced
this pull request
Mar 5, 2024
* Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Update iOS agent to 7.4.6 (#73) * Update iOS Version to 7.4.6 * Release 6.2.3 --------- Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com> Co-authored-by: ndesai-newrelic <89222514+ndesai-newrelic@users.noreply.github.com> * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * resolve merge conflicts with master * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * resolve merge conflicts with master * merge with master * feature: added offline storage functionality for cordova --------- Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com>
ndesai-newrelic
added a commit
that referenced
this pull request
Mar 5, 2024
* Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Update iOS agent to 7.4.6 (#73) * Update iOS Version to 7.4.6 * Release 6.2.3 --------- Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com> Co-authored-by: ndesai-newrelic <89222514+ndesai-newrelic@users.noreply.github.com> * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * resolve merge conflicts with master * fix fetch instrumentation bugs --------- Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com>
ndesai-newrelic
added a commit
that referenced
this pull request
Mar 5, 2024
* Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Update iOS agent to 7.4.6 (#73) * Update iOS Version to 7.4.6 * Release 6.2.3 --------- Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com> Co-authored-by: ndesai-newrelic <89222514+ndesai-newrelic@users.noreply.github.com> * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * resolve merge conflicts with master * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * Add optional attributes for recordError (#69) * feat: add optional attributes parameter for javascript code * feat: handle optional attributes for record error in native code * test: add unit tests for optional attributes parameter in record error * feat: add boolean type for value in optional attributes for record error * test: modify test for record error to test boolean and number values in optional attributes * feat: update README documentation for record error to include optional attributes * resolve merge conflicts with master * merge with master * feature: added offline storage functionality for cordova --------- Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ndesai-newrelic <gh-actions-ndesai-newrelic@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR allows optional custom attributes for recordError in the Cordova plugin.
Description
The Javascript and native (Objective-C, Java) code for recordError has been modified to handle an additional optional parameter for custom attributes to be recorded. The unit tests for recordError have been modified to test this new functionality of recording custom attributes. In addition, the README has been updated to reflect the update to recordError.