This repository has been archived by the owner on Jun 2, 2021. It is now read-only.
Use full service domain for the CN #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EKS is not adding the Subject Alternative Name (SAN) when signing the CSR. This means that we cannot use service name without specifying the namespace and `.svc` suffix. As you can see from the apiserver error message, the TLS certificate validation is checking only the CN. x509: certificate is valid for newrelic-metadata-injection-svc, not newrelic-metadata-injection-svc.default.svc This is a known issue in EKS: awslabs/amazon-eks-ami#341 This changes revert to using {service}.{namespace}.svc for the CN but check the length to be withing the limit of 64 characters defined on the x509 specification.
alejandrodnm
force-pushed
the
adn/use_full_domain_for_CN
branch
from
311d000
to
f7118b8
Compare
douglascamata
approved these changes
Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EKS is not adding the Subject Alternative Name (SAN) when signing the CSR.
This means that we cannot use service name without specifying the
namespace and
.svcsuffix.As you can see from the apiserver error message, the TLS certificate
validation is checking only the CN.
x509: certificate is valid for newrelic-metadata-injection-svc, not newrelic-metadata-injection-svc.default.svc
This is a known issue in EKS:
awslabs/amazon-eks-ami#341
This changes revert to using {service}.{namespace}.svc for the CN but
check the length to be withing the limit of 64 characters defined on the
x509 specification.