Skip to content

Conversation

@longwa
Copy link
Contributor

@longwa longwa commented Oct 2, 2020

Allows configuring the maxStackSize on the NewRelicEncoder for logback.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2020

CLA assistant check
All committers have signed the CLA.

@jeffalder
Copy link
Contributor

This is great, thanks for the contribution! Is this settable via XML as-is? If not, what would it take?

Copy link
Contributor

@breedx-nr breedx-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! This is a great idea.
Overall, it does look good, but I did have a few small suggestions and a question.

@longwa
Copy link
Contributor Author

longwa commented Oct 3, 2020

This is great, thanks for the contribution! Is this settable via XML as-is? If not, what would it take?

I'll create a simple test project in Java using XML and test it shortly. Thanks for considering the change.

Copy link
Contributor

@breedx-nr breedx-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@breedx-nr breedx-nr merged commit 4bbc529 into newrelic:main Oct 6, 2020
@cortexcompiler
Copy link

cortexcompiler commented Apr 13, 2022

Does this mean that the README could be updated to show that this is supported? :

        <encoder class="com.newrelic.logging.logback.NewRelicEncoder">
        	<maxStackSize>50</maxStackSize>
        </encoder>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants