-
Notifications
You must be signed in to change notification settings - Fork 22
Fix #29: Make maxStackSize configurable #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is great, thanks for the contribution! Is this settable via XML as-is? If not, what would it take? |
breedx-nr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! This is a great idea.
Overall, it does look good, but I did have a few small suggestions and a question.
logback/src/main/java/com/newrelic/logging/logback/NewRelicJsonLayout.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/newrelic/logging/core/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
logback/src/main/java/com/newrelic/logging/logback/NewRelicEncoder.java
Outdated
Show resolved
Hide resolved
I'll create a simple test project in Java using XML and test it shortly. Thanks for considering the change. |
breedx-nr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help!
|
Does this mean that the README could be updated to show that this is supported? : |
Allows configuring the maxStackSize on the
NewRelicEncoderfor logback.