-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop classifying INFRA-WIN_SERVICE data as EXT-SERVICE #1723
Stop classifying INFRA-WIN_SERVICE data as EXT-SERVICE #1723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate that we do not know the history of why the service_name
and serviceName
rules exist. They certainly have nothing to do with OpenTelemetry, so @jack-berg and myself would not know the history.
I guess there's a small risk here that there exists entities today that are correctly classified as EXT-SERVICE that use service_name
and also collector.name
. Though this would be strange since they would unlikely light up any UI experience.
Can anyone from the entity platform team provide any insight into the extent that service_name
and serviceName
are used? It'd be great if we could find a way to delete them if possible.
In summary, I believe it is because it was one of the first rules we created (which predates this public repository) and we were trying to match data points for distinct integrations (e.g. logging used I am not sure if those integrations are using new rules now or they keep relying on what is here. A bit of code archeology this one to be fairly honest. I have send you some historical data via Slack, hope it helps! |
See https://new-relic.atlassian.net/browse/NR-285288.
cc @alanwest