Fix hover legend #347
Merged
Fix hover legend #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really sure why the check fails... |
Indigo744
force-pushed
the
fix_hover_legend
branch
from
207b859 to
1d135f5
Compare
|
Weird, I get the same error on master... |
|
Fixed by #348 |
neveldo
approved these changes
Nov 6, 2017
There was a problem hiding this comment.
Hello @Indigo744 , great catch ! (my bad, I admit that I didn't check all of the usecases in our code samples when reviewing the previous PRs !). I saw that you have removed some useless checks, and simplified some types checks thanks to dataTypeToElementMapping :)
|
Indeed, it was something that I missed the first time I implemented the dataTypeToElementMapping ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #319 (event delegation) introduces (another) regression regarding legend element hovering.
This PR fixes that.