Skip to content

Conversation

@neutronth
Copy link
Owner

@neutronth neutronth commented Sep 15, 2023

Refactor: Bring everything up to speed with new deps and node 20

  • Based on works of John McBride (@jpmcb)
  • Update dependencies:
    • Bump:
      • @typescript-eslint/eslint-plugin: ^6.7.0
      • @typescript-eslint/parser: ^6.7.0
      • eslint: ^8.49.0
      • typescript: ^5.2.2
    • Add:
      • eslint-import-resolver-typescript: ^3.6.0
        Required for eslint to work with typescript import resolver
      • msw: ^1.3.1
        Introduced to replace nock
    • Replace deprecated:
      • Replace @zeit/ncc with @vercel/ncc, upstream suggestion
        Build error: digital envelope routines::unsupported
    • Drop:
      • nock due to the issue [1] related to the fetch experimental
        feature of nodejs
  • Refactor code:
    • TypeScript compile errors
    • ESLint errors and warnings
    • Tests reimplement GitHub API responses mockup using msw/node instead
      of nock
  • Declare the action runs using node20

[1] nock/nock#2397

Signed-off-by: John McBride <jpmmcbride@gmail.com>
@jpmcb
Copy link

jpmcb commented Sep 15, 2023

Hi @neutronth - this is awesome. I have a draft that I've been slowly hacking on in the upstream repo: jpmcb#79

Are you interested in tackling this and getting these changes into the upstream repo? No sense in fracturing the project and having dispersed forks out and about. If not, I'll likely use this as a basis for getting stuff up to speed in the upstream repo.

* Based on works of John McBride (@jpmcb)
* Update dependencies:
  + Bump:
    + @typescript-eslint/eslint-plugin: ^6.7.0
    + @typescript-eslint/parser: ^6.7.0
    + eslint: ^8.49.0
    + typescript: ^5.2.2
  + Add:
    + eslint-import-resolver-typescript: ^3.6.0
      Required for eslint to work with typescript import resolver
    + msw: ^1.3.1
      Introduced to replace nock
  + Replace deprecated:
    + Replace @zeit/ncc with @vercel/ncc, upstream suggestion
      Build error: digital envelope routines::unsupported
  + Drop:
    + nock due to the issue [1] related to the fetch experimental
      feature of nodejs
* Refactor code:
  + TypeScript compile errors
  + ESLint errors and warnings
  + Tests reimplement GitHub API responses mockup using msw/node instead
    of nock
* Declare the action runs using node20

---
[1] nock/nock#2397

Signed-off-by: Neutron Soutmun <neutron.s@linecorp.com>
@neutronth
Copy link
Owner Author

Hi @neutronth - this is awesome. I have a draft that I've been slowly hacking on in the upstream repo: jpmcb#79

Are you interested in tackling this and getting these changes into the upstream repo? No sense in fracturing the project and having dispersed forks out and about. If not, I'll likely use this as a basis for getting stuff up to speed in the upstream repo.

@jpmcb - It's my pleasure.
I'm preparing the patches and will open the PR to your upstream repository.
Please let me prepare and need your review as well.

Signed-off-by: Neutron Soutmun <neutron.s@linecorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants