Draft: re-instanciate MarkdownX on formset:added #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I really hope you understand my idea here - these are the first lines of typescript in my life, so I'm more than happy to accept feedback. Also I guess the failing test seems unrelated to my code change, maybe something is broken in master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #275
Trigger
markdownx-classes onformset:added: Django will create a "template" for each inline and copy it every time the user selects to add a new form. Sadly during cloning the event listeners are not cloned (and would not know their targets), so this PR simply re-instanciates MarkdownX for these elements.Note that as the form is cloned, the
data-markdownx-initis already set.