Revert "v0.50.10" #59
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| halt = true | ||
|
|
||
| case app.haltTime > 0 && time.Unix() >= int64(app.haltTime): | ||
| case app.haltTime > 0 && time.Unix() > int64(app.haltTime): |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error
| break | ||
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) | ||
| wireType := int(wire & 0x7) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| break | ||
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) | ||
| wireType := int(wire & 0x7) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) | ||
| wireType := int(wire & 0x7) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| break | ||
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) | ||
| wireType := int(wire & 0x7) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| break | ||
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) | ||
| wireType := int(wire & 0x7) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error test
| for name := range modules { | ||
| mods = append(mods, " "+string(name)) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| @@ -1,7 +1,11 @@ | |||
| package appmodule | |||
|
|
|||
| import ( | |||
| depinjectappconfig "cosmossdk.io/depinject/appconfig" | |||
| "reflect" | |||
Check notice
Code scanning / CodeQL
Sensitive package import Note
|
|
||
| import ( | ||
| "fmt" | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
| for _, initializer := range ModuleRegistry { | ||
| descriptor := initializer.ConfigProtoMessage.ProtoReflect().Descriptor() | ||
| fullName := descriptor.FullName() | ||
| if _, ok := res[fullName]; ok { | ||
| return nil, fmt.Errorf("duplicate module registratio for %s", fullName) | ||
| } | ||
|
|
||
| modDesc := proto.GetExtension(descriptor.Options(), appv1alpha1.E_Module).(*appv1alpha1.ModuleDescriptor) | ||
| if modDesc == nil { | ||
| return nil, fmt.Errorf( | ||
| "protobuf type %s registered as a module should have the option %s", | ||
| fullName, | ||
| appv1alpha1.E_Module.TypeDescriptor().FullName()) | ||
| } | ||
|
|
||
| if modDesc.GoImport == "" { | ||
| return nil, fmt.Errorf( | ||
| "protobuf type %s registered as a module should have ModuleDescriptor.go_import specified", | ||
| fullName, | ||
| ) | ||
| } | ||
|
|
||
| res[fullName] = initializer | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| protoiface "google.golang.org/protobuf/runtime/protoiface" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| io "io" | ||
| reflect "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note test
| if fd.IsExtension() { | ||
| panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.TestUnregisteredModule")) | ||
| } | ||
| panic(fmt.Errorf("message testpb.TestUnregisteredModule does not contain field %s", fd.FullName())) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning test
| switch fd.FullName() { | ||
| default: | ||
| if fd.IsExtension() { | ||
| panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.TestNoModuleOptionModule")) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning test
| if fd.IsExtension() { | ||
| panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.TestNoModuleOptionModule")) | ||
| } | ||
| panic(fmt.Errorf("message testpb.TestNoModuleOptionModule does not contain field %s", fd.FullName())) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning test
| switch fd.FullName() { | ||
| default: | ||
| if fd.IsExtension() { | ||
| panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.TestNoGoImportModule")) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning test
| if fd.IsExtension() { | ||
| panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.TestNoGoImportModule")) | ||
| } | ||
| panic(fmt.Errorf("message testpb.TestNoGoImportModule does not contain field %s", fd.FullName())) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning test
Reverts #57