Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: implement fast lookups for module location and version #161

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

neutrinoceros
Copy link
Owner

closes #140

@neutrinoceros neutrinoceros added the enhancement New feature or request label Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #161 (8af25ef) into main (5a7fcd3) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   98.16%   98.23%   +0.07%     
==========================================
  Files          10       10              
  Lines         435      454      +19     
==========================================
+ Hits          427      446      +19     
  Misses          8        8              
Flag Coverage Δ
unittests 98.23% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wxc/cli.py 95.09% <100.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7fcd3...8af25ef. Read the comment docs.

@neutrinoceros neutrinoceros force-pushed the quick_module_search branch 2 times, most recently from 0c4da7b to eb9bcd2 Compare July 20, 2022 15:46
@neutrinoceros neutrinoceros marked this pull request as ready for review July 20, 2022 15:48
@neutrinoceros neutrinoceros merged commit 417dce1 into main Jul 20, 2022
@neutrinoceros neutrinoceros deleted the quick_module_search branch July 20, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use importlib.util.find_spec for quick lookups
1 participant