Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add rich transient progress spinner #124

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

neutrinoceros
Copy link
Owner

@neutrinoceros neutrinoceros commented Aug 24, 2021

need to figure out if this is worth adding rich as a mandatory dependency (probably not, but it's fun though).

TODO:

  • edit changelog
  • edit README (stop boasting about not having dependencies in Python 3.10)

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #124 (163d73a) into main (191bab4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          10       10           
  Lines         375      377    +2     
=======================================
+ Hits          372      374    +2     
  Misses          3        3           
Flag Coverage Δ
unittests 99.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wxc/cli.py 97.01% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191bab4...163d73a. Read the comment docs.

@neutrinoceros neutrinoceros force-pushed the rich_progress_import branch 2 times, most recently from c141679 to 0750c45 Compare August 25, 2021 10:30
@neutrinoceros neutrinoceros changed the title ENH: add rich transient progress spinner (experimental) ENH: add rich transient progress spinner Aug 25, 2021
@neutrinoceros neutrinoceros added the enhancement New feature or request label Aug 25, 2021
@neutrinoceros neutrinoceros marked this pull request as ready for review August 25, 2021 11:44
@neutrinoceros neutrinoceros merged commit 38c19c2 into main Aug 25, 2021
@neutrinoceros neutrinoceros deleted the rich_progress_import branch August 25, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant