-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] fix name of nimare to be pep 625 compliant #917
Conversation
Reviewer's Guide by SourceryThis pull request changes the package name in No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jdkent - I've reviewed your changes - here's some feedback:
Overall Comments:
- This is a straightforward change, but it would be good to confirm that this change doesn't break any existing workflows or dependencies.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 48 48
Lines 6383 6383
=======================================
Hits 5632 5632
Misses 751 751 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes # .
Changes proposed in this pull request:
Summary by Sourcery
Chores: