-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] name of distribution conform to PEP 625 #916
Conversation
Reviewer's Guide by SourceryThis pull request updates the setuptools version to 69.5.1 in both the GitHub Actions workflow and the pyproject.toml file. This change ensures compliance with PEP 625, as version 69.3.0 and later of setuptools supports PEP 625. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jdkent - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great you've pinned the setuptools version, but consider adding a comment in
pyproject.toml
as well to explain why.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 48 48
Lines 6383 6383
=======================================
Hits 5632 5632
Misses 751 751 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes # .
Changes proposed in this pull request:
Summary by Sourcery
Update setuptools to version 69.5.1 to ensure the distribution name conforms to PEP 625.
Build: