Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add similarity correlation matrix figure to IBMA reports #852

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

JulioAPeraza
Copy link
Collaborator

Closes #847.

Changes proposed in this pull request:

  • Adding a similarity-sorted correlation matrix figure to the summary section of the IBMA reports.

@JulioAPeraza JulioAPeraza added enhancement New feature or request ibma Issues/PRs pertaining to image-based meta-analysis labels Dec 13, 2023
@JulioAPeraza
Copy link
Collaborator Author

@JulioAPeraza JulioAPeraza requested a review from tsalo December 13, 2023 16:32
@tsalo
Copy link
Member

tsalo commented Dec 13, 2023

The figure looks great, although I'm not sure about the map sorting. What sorting method do you use?

@JulioAPeraza
Copy link
Collaborator Author

I'm using scipy.cluster.hierarchy.linkage with the method average for this matrix. I found that the diagnostic table looks better with single. Would you suggest a different method for the correlation matrix?

Here is a figure using complete:

image

@JulioAPeraza
Copy link
Collaborator Author

Using single:

image

@tsalo
Copy link
Member

tsalo commented Dec 13, 2023

It looks like they're the same either way. "single" sounds good. Thanks for trying it both ways!

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (720c5c6) 89.12% compared to head (341045b) 89.14%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   89.12%   89.14%   +0.01%     
==========================================
  Files          49       49              
  Lines        6142     6152      +10     
==========================================
+ Hits         5474     5484      +10     
  Misses        668      668              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdkent jdkent merged commit 9c4d2ea into neurostuff:main Dec 14, 2023
@JulioAPeraza JulioAPeraza deleted the enh-ibma-report branch December 14, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ibma Issues/PRs pertaining to image-based meta-analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add similarity-sorted correlation matrix figure to IBMA reports
3 participants