-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add similarity correlation matrix figure to IBMA reports #852
Conversation
The figure looks great, although I'm not sure about the map sorting. What sorting method do you use? |
I'm using scipy.cluster.hierarchy.linkage with the method Here is a figure using |
It looks like they're the same either way. "single" sounds good. Thanks for trying it both ways! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
+ Coverage 89.12% 89.14% +0.01%
==========================================
Files 49 49
Lines 6142 6152 +10
==========================================
+ Hits 5474 5484 +10
Misses 668 668 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #847.
Changes proposed in this pull request: