Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make torch optional #836

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Make torch optional #836

merged 8 commits into from
Sep 18, 2023

Conversation

JulioAPeraza
Copy link
Collaborator

Closes #806.

Changes proposed in this pull request:

  • Make torch optional.
  • Test raise ImportError.

@JulioAPeraza JulioAPeraza added the enhancement New feature or request label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (63f0a7e) 89.08% compared to head (d6153d4) 89.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
+ Coverage   89.08%   89.09%   +0.01%     
==========================================
  Files          48       48              
  Lines        6102     6108       +6     
==========================================
+ Hits         5436     5442       +6     
  Misses        666      666              
Files Changed Coverage Δ
nimare/meta/cbmr.py 78.51% <100.00%> (+0.18%) ⬆️
nimare/meta/models.py 90.36% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JulioAPeraza

@jdkent jdkent merged commit 32577f7 into neurostuff:main Sep 18, 2023
@JulioAPeraza JulioAPeraza deleted the optional-torch branch September 18, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch is a heavy requirement
2 participants