handle case of no sample size being reported #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 41 41
Lines 4856 4859 +3
=======================================
+ Hits 4318 4321 +3
Misses 538 538
☔ View full report in Codecov by Sentry. |
tsalo
reviewed
May 8, 2023
| @@ -204,7 +204,7 @@ def __init__(self, source): | |||
| self.name = source["name"] or "" | |||
| self.authors = source["authors"] or "" | |||
| self.publication = source["publication"] or "" | |||
| self.metadata = source.get("metadata", {}) | |||
| self.metadata = source.get("metadata", {}) or {} | |||
There was a problem hiding this comment.
Shouldn't source.get("metadata", {}) default to {} anyway?
There was a problem hiding this comment.
it was a little bit of a thinker. if I have a study object like so:
{
"name": "test"
}then source.get("metadata", {}) will return {}, but if the study object looks like the following:
{
"name": "test",
"metadata": null
}then source.get("metadata", {}) returns None.
There was a problem hiding this comment.
ohhh.... that makes sense. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # .
Changes proposed in this pull request: