-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pre-generated maps in CorrelationDecoder
#782
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d5a3162
Support pre-generated maps in CorrelationalDecoder
JulioAPeraza f731f36
[skip ci] fix circular import
JulioAPeraza 389bb05
Test new functionality
JulioAPeraza 78188d2
Merge branch 'neurostuff:main' into enh-decoder
JulioAPeraza 862d1f4
Add load_imgs method to CorrelationDecoder
JulioAPeraza 263b9c5
fix linting issues
JulioAPeraza f023304
Update continuous.py
JulioAPeraza 423f275
Return a MetaResult object
JulioAPeraza 4c60f9a
Improve coverage
JulioAPeraza fb21ce8
Update base.py
JulioAPeraza cc414d6
Apply @adelavega suggestions. change `fit` and `load_imgs` to work in…
JulioAPeraza 2e80e00
Update continuous.py
JulioAPeraza 5646893
Apply @adelavega suggestions.
JulioAPeraza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only question is whether we should allow this to be configurable and allow only the data frame the returned?
This would prevent a lot of copies of the
MetaResult
object and images if somebody is doing multiple decodings and doesn't want to save the images.Also-- what happens when you save a
MetaResult
object? Do the images get saved or also thetables
?