Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MACM analysis example #750

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

JulioAPeraza
Copy link
Collaborator

Closes None.

Changes proposed in this pull request:

  • I think atlas["maps"] is already a nibabel.nifti1.Nifti1Image object. Using nib.load on atlas["maps"] will raise the error:
TypeError: stat: path should be string, bytes, os.PathLike or integer, not Nifti1Image

@JulioAPeraza JulioAPeraza added the documentation Improving documentation for the project label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 88.55% // Head: 88.05% // Decreases project coverage by -0.50% ⚠️

Coverage data is based on head (6f83304) compared to base (e269941).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   88.55%   88.05%   -0.51%     
==========================================
  Files          38       35       -3     
  Lines        4370     3884     -486     
==========================================
- Hits         3870     3420     -450     
+ Misses        500      464      -36     
Impacted Files Coverage Δ
nimare/__init__.py
nimare/utils.py
nimare/base.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, checked the oldest version of nilearn that NiMARE supports, and it looks like it should be a nifti image and not a filename:
https://github.com/nilearn/nilearn/blob/ad04ee8ce91fde193fe4627f666ddeb52271a383/nilearn/datasets/atlas.py#L271-L429

@jdkent jdkent merged commit f523475 into neurostuff:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improving documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants