Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift centers of mass into clusters in Jackknife/FocusCounter #735

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 27, 2022

Closes None, but this will work well with the recent changes to Nilearn's get_clusters_table that shift centers of mass into clusters.

Changes proposed in this pull request:

  • Shift centers of mass of clusters into the nearest within-cluster voxel in the diagnostic tools.
  • Replace scipy sub-submodule use (e.g., scipy.ndimage.measurements.label()) with the submodule (scipy.ndimage.label()), per scipy's recommendations.
  • Add a License section to docstrings for functions using external code.

@tsalo tsalo added bug Issues noting problems and PRs fixing those problems. diagnostics Issues/PRs related to the diagnostics module. labels Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #735 (a054229) into main (44b1011) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   88.91%   88.95%   +0.04%     
==========================================
  Files          40       40              
  Lines        4439     4456      +17     
==========================================
+ Hits         3947     3964      +17     
  Misses        492      492              
Impacted Files Coverage Δ
nimare/transforms.py 75.71% <ø> (ø)
nimare/diagnostics.py 93.43% <100.00%> (-0.19%) ⬇️
nimare/meta/cbma/base.py 97.10% <100.00%> (ø)
nimare/meta/cbma/mkda.py 98.78% <100.00%> (ø)
nimare/meta/utils.py 95.83% <100.00%> (ø)
nimare/utils.py 94.86% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b1011...a054229. Read the comment docs.

@tsalo tsalo merged commit f72500d into neurostuff:main Jul 28, 2022
@tsalo tsalo deleted the fix-coms branch July 29, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems. diagnostics Issues/PRs related to the diagnostics module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant