Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note why we don't implement TFCE in NiMARE (currently) #680

Merged
merged 3 commits into from
May 12, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented May 12, 2022

Closes #145 and closes #655.

NOTE: I still hope to implement a fast probabilistic TFCE method in the future.

Changes proposed in this pull request:

  • Add a note to the documentation about why we're not going to implement TFCE in NiMARE.

@tsalo tsalo added the documentation Improving documentation for the project label May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #680 (0de68a7) into main (b186fb4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files          41       41           
  Lines        4528     4528           
=======================================
  Hits         3863     3863           
  Misses        665      665           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b186fb4...0de68a7. Read the comment docs.

@tsalo tsalo merged commit acca113 into neurostuff:main May 12, 2022
@tsalo tsalo deleted the doc-tfce branch May 12, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improving documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include TFCE thresholding
1 participant